@pikapikamart
Posted
Hey, awesome work on this one. Layout looks great in desktop, it is responsive and the mobile state looks great as well.
You already got some feedbacks on this, just going to add some small suggestions:
- Do not use
a
tag for the accordion toggle since those are not links, usebutton
instead because it is a control element for the accordion. - If you are going to use
button
don't forget to add a defaultaria-expanded="false"
attribute on it, it will be set totrue
if the users toggles thebutton
and vice-versa. This will let your users know that is has expanded something to be seen. - The dropdown
svg
should be hidden so addaria-hidden="true"
on it. Remember to always hide decorative images.
Aside from those, great work again on this one.
Marked as helpful
@JulienLEUILLIER
Posted
@pikamart Very nice of you to take the time ! Thank you, I will look all those up.