Looking to hire developers?
I would appreciate some feed back on how I could have optimise my CSS. Thank you :)
@martinelias1312
Posted
Hi @Eric-Ferole, i recommend using relative units like em, rem or % instead of absolute units (px). This will surely help with page responsiveness. Here is an article about units.
Hope this will help you for future challenges :)
@Eric-Ferole
Posted
@smradupan your are right. I read about rem. Seems pretty useful for responsiveness and accessibility. Thanks for you comment.
@IEdiong
Posted
Hello Eric 👋, your solution is almost 💯 pixel perfect. I did notice two things:
the cancel button is meant to have its text-decoration set to none
Also, you should look into the accessibility and HTML issues raised here.
I hope this was helpful, Shalom!
@Eric-Ferole
Posted
@IEdiong Thanks for you comment. You are right. I'll take care of those issues later today.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
