Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Landing Page using HTML and CSS

Mario Yanezβ€’ 10

@MarioY99

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I loved this challenge.

Community feedback

Lucas πŸ‘Ύβ€’ 104,580

@correlucas

Posted

πŸ‘ΎHello Mario, congratulations for your new solution!

I saw your solution and the code, I've some tips for you:

You don't need to use too much stuff to build this card, for example, you don't need many divs here, you can have the component with a single div holding everything (h1, img, and p).

To have your component responsive, pay attention that you've add many properties for the width the CSS recognize only one, so prefer to use max-width for a responsive card, if you add width it gets a fixed size and don't behave flexible.

.main_container {
    /* position: relative; */
    max-width: 320px;
    /* min-width: 280px; */
    /* max-width: 328px; */
    background: var(--white);
    /* margin: 20px; */
    padding: 20px;
    border-radius: 14px;
}

πŸ‘‹ I hope this helps you and happy coding!

0

@VCarames

Posted

Congrats on completing this challenge!

Some suggestions:

Remove the your width: 87.5% and min-width: 200px from your main-container class. You already have a max-width: 328px, no need for additional widths.

For your image, delete everything except for width: 100% and border-radius: 8px.

Keep up the good work!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord