Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive page with popups using HTML CSS and JS

@Adetuyi

Desktop design screenshot for the Crowdfunding product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I need scrutiny on my my code css and js specifically Is it a good idea to avoid using flex at all with IE8 and IE9 in mind or just ignore those users? I need help in pointing out unnecessary codes/ immature codes Thanks in advance

Community feedback

P
Grace• 27,670

@grace-snow

Posted

Hi Adetuyi,

This looks pretty good and you've clearly done a lot of work here, but I think you could still get it closer to the design. Really try to pay attention to small details. Like spacing, sizing of elements relative to each other, width of borders, line spacing etc.

The html needs some work still. It's not accessible at the moment because you've used non-interactive elements like divs for click events (always use interactive html elements like buttons or anchor tags).

Document semantics are also missing because most text is in spans instead of meaningful html elements. That will make it very difficult for search engines and assistive tech to traverse your site. The page also needs a h1.

Looking at the javascript, it's OK and all functions fine, but it's using old methods. Try to leverage es6 in this - const or let, arrow functions etc. See if there are ways for you to Shorten and simplify the code.

It sounds like I'm listing lots of things, but they are all pretty easy to fix and fundamental to good practice. Spend extra time giving really good attention to detail and you'll notice the difference in your projects.

Good. Luck ☺

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord