Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Room homepage | Pug, Scss & Vanilla JS

MasterKrab 940

@MasterKrab

Desktop design screenshot for the Room homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am just a beginner and would appreciate any feedback.

Do I have good practices? What errors do I have? How could I improve my code?

Thanks <3

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hello, MasterKrab! 👋

Good to see you complete this challenge! 😀 Nice job on it! 🙌 Your solution looks good and the image slider works well! 👍 I especially like the focused state that you gave to the slider buttons of the image slider (those dotted borders look pretty cool)! 👏

This is a minor thing but on my screen, there seems to be a little extra white space between the top row and the bottom row of the content in the desktop layout. Eliminating that extra space to bring the two rows closer together (as in the original design) would be nice! 😉

Keep coding (and happy coding, too)! 😁

2

MasterKrab 940

@MasterKrab

Posted

@ApplePieGiraffe Thank you so much

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord