@mattstuddert
Posted
Great work, Aleem! Congrats on submitting your first solution 🎉
Here are some answers to your questions:
- There isn't really a single fastest way to create any given layout. You'll become faster with every project you build. Everyone has their own workflow as well, so it's a great idea to just keep practicing so that you can find the workflow that suits you best.
- I always use the
rem
unit forfont-size
declarations. This always me to simply change thefont-size
on thehtml
element to scale all sizes up and down. I'll userem
units for spacing as well, so that every scales proportionally. It's great to see that you're already doing this 👍 - Here are some pointers after taking a look at your code:
- I'd recommend having a go at using
min-width
media queries instead ofmax-width
. Doing this and working mobile-first often leads to less CSS code and has the benefit of loading in fewer styles for mobile users. - I'd recommend only using a single
h1
heading. Having multiple can cause accessibility issues, so having a single one is recommended. - In the Why Us area, you're using a paragraph, whereas it's a list of features/benefits, so a
ul
would be a great option here.
- I'd recommend having a go at using
I hope these tips help. Keep up the great work and let me know if you have any questions!
@Aleemcode
Posted
@mattstuddert Thanks for the reply. Well detailed and insightful, I really appreciate that. I'll look into the changes you raised and implement them likewise the tips.
@mattstuddert
Posted
@Aleemcode you're welcome!