@shashilo
Posted
Great job with this solution. From a glance, it's pretty darn exact to the design. Roman is right about not setting a fixed widths. You have it set in many places and it's not allowed to be fluid to the viewport of a browser window. If you inspect the .container
, you can see that the box-model is incorrect. There's a max-width that is too small for the .container itself. When you resize your browser to <1230px, the fixed width overflows. According to the style guide, the max-width should actually be 1440px. Because you are using CSS Grid, research how to work with fr
units instead of fixed px
widths.
Some nit picky things:
- I would like this centered to the browser. It look's off left aligned.
- The hover state color is off from the design.
<article>
has some additional grid attributes that are not needed because <aside> already sets up the grid for this group.
@alonsomacarena
Posted
@shashilo thank you so much for your input! I'll take everything into consideration to improve on my coding abilities.