Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Proof Section - My final newbie challenge!

drallasβ€’ 375

@Drallas

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This was my final newbie challenge and I had fun again building it, more details about my process are in the readme.

Feedback is very much welcome I'd like to learn and improve my skills! I'm curious if my approach is correct and what i should consider refactoring or doing different next challenge..

Community feedback

Folarin Akinloyeβ€’ 1,240

@folathecoder

Posted

Hi Drallas!

Your implementation is clean and looks great. Congrats on your journey and keep it up!

The responsiveness of the page is great on only desktop and mobile. The tablet view should not take the form of a mobile screen. Try to make that tablet more responsive or look more like a tablet by making great use of the available space. You can make the tablet layout look like the desktop, with minor tweaks!

Also, your testimonial cards should have a min-height and not a fixed height. Declaring a fixed height will make the content inside the cards to pop out when the screen is smaller. You can test this by displaying the page on a 240px-width screen.

A min-height will allow the content inside the card to determine the height of the card.

.cards__item { text-align: left; height: 248px; (min-height: 248px) color:hsl(0, 0%, 100%); border-radius: 8px; background-color: var(--very-dark-magenta); margin-bottom: 1rem; }

Just a few suggestions, I hope it helps...... Feel free to correct me if I am wrong!

Happy Coding!

3

drallasβ€’ 375

@Drallas

Posted

@folathecoder

Thank you for your feedback, i will definitely refactor later today taking your feedback into account!

Greetings..

1
P
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

Hello there, drallas! πŸ‘‹

Just wanted to drop in to say congratulations upon completing your final newbie challenge! πŸŽ‰ It's great to hear that you had fun building it and you've done a good job! πŸ‘

Simply follow Fola's helpful suggestions and I think you'll be good to go! πŸ˜€

Of course, keep coding (and happy coding, too)! 😁

0

drallasβ€’ 375

@Drallas

Posted

@ApplePieGiraffe Hi APG tnx for your drop-in, I implemented most of Fola suggestions and now I'm already having fun with the next challenge :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord