P
Matt Studdert• 13,611
@mattstuddert
Posted
Nice work on this challenge and congrats on submitting your first solution! Here are a couple of pointers after taking a look at your code:
- Avoid using IDs as CSS selectors. They have high specificity and can't be reused on the page, so they're not good for the purpose of styling. Instead, I'd recommend sticking to class, attribute, pseudo, and type selectors. Using these will help keep your CSS more maintainable.
- The responsive side of your project could do with a review. From
376px
up to small desktop size, the layout doesn't fit the screen creating a horizontal scrollbar. Have you ever tried usingmin-width
media queries instead ofmax-width
? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain. It is also simpler than mixing bothmin-width
andmax-width
, as you've done.
I hope these pointers help. Let me know if you have any questions. Keep up the great work!
0
prisnak• 10
@prisnak
Posted
@mattstuddert Thanks a lot for this feedback. I will pay attention on those points next time. :)
0