@0xabdulkhalid
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE TESTIMONIALS :
- Currently the Testimonials are not accessible because of using
section
element which has no semantic relations for testimonials, Actually we need to use<figure>
and<blockquote>
elements to wrap the testimonials.
- For example:
<figure>
<figcaption>
<img src="./assets/images/image-daniel.jpg" alt="Daniel Clifford" />
<div>
<p>
<span class="sr-only">Testimony Author</span>
Daniel Clifford
</p>
<p>Verified Graduate</p>
</div>
</figcaption>
<blockquote>
<h2>
Testimonial Title
...
</h2>
<p>
Testimonial Quote
...
</p>
</blockquote>
</figure>
- Additionally, you want to add proper
alt
forimg
inside testimonials instead of empty onealt=""
because they are not for decoration, It will help us to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value likealt="Daniel Clifford"
- If you have any questions or need further clarification feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@adrian-reina-391
Posted
@0xabdulkhalid Done, thanks for the suggestions