1) I have problems with the image (mobile), it's too big.
2) I couldn't change the border radius (desktop) in the correct corners.
3) I wasn't able to use "calc()" to change "inline-height". Tried to use "variable + 0.2", and nothing happend. I was using .SCSS to do it.
4) It's the first time i use ITCSS (Was a mess on my mind organizing it, i don't know if i put them in the right folders )
Thank you for all your feedback whit this points and other mistakes you can see and share me ❤
I'm really confused about a lot of things in this project. I used a lot of hacky css. It doesn't scale the way i want. Your criticism and corrections will go a long way please. CSS is hard...
- Jackson Jude135Submitted
Any feedback is greatly appreciated! :)
I would love some feedback!
Hello everybody, for sure my solution is not perfect yet. Any advice for improving it is well appreciated. In the specific It would be nice to get an estimation in terms of time: If some experienced front-end developer can tell me (hours/days) how long can take to finish this project (around) it is really good for me to value myself. Thank you. Happy to be part of this community.
This is my (admittedly messy) solution using React. I've only recently started learning/using react so I understand that I should refactor the code to split into further components (e.g. a component for the slider).
Any suggestions on how to improve, including whether I am using useEffect() correctly, would be appreciated. I know useEffect & setState trigger re-renders so I am not sure whether this solution is performant. I assume it is not.
Join our Slack community
Join over 50,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!
Subscribe to our newsletter
Stay up-to-date with new challenges, featured solutions, selected articles and Frontend Mentor latest news