Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

E-Commerce Site using HTML, CSS & JavaScript

Elizabeth C•360
@Esagecc
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I wanted to build an E-Commerce site to know the main components that would make an effective shopping site. It was a great exercise.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Elaine•11,360
    @elaineleung
    Posted almost 3 years ago

    Hi Elizabeth, this looks really great, I think you did a good job overall getting it to look as close as possible to the design in the desktop view 😊

    It looks like the image links are broken right now, so I can't see the thumbnails or the other images when I click on them; what you can do is to add a dot right before the slash in your image path to indicate the current working directory.

    Some other points I have that might help you:

    The image thumbnail containers look quite elongated depending on the browser width, and it looks like it could be due to the fixed height you set. What I would do is to remove the fixed height of 90px on the image container, and in the .pic img I'd add this:

      .pic img {
        width: 100%;
        height: 100%;
        object-fit: cover;
        display: block;
      }
    

    It would be even better if you are using a reset rule for images already, and if you're not doing yet, I highly suggest using reset rules for all your projects!

    Lastly, you can try different settings for the images and containers for better responsiveness, as right now when I make the browser smaller, the image container shrinks a bit too much. I think this has to do with your width only using percentages; I would try using something like width: min(90%, 60em) for the main container instead where the browser can choose a minimum width from the choices given. Also in mobile view, you may need a margin-inline: auto (as in margin: 0 auto) to make things centered, and also to remove the side margin/padding you have in the other containers in this view so that things would line up.

    Great job again, and keep going!

  • Elizabeth C•360
    @Esagecc
    Posted almost 3 years ago

    Thank you for the input. I will get back to improving my broken links. I really wanted to make the site presentable to add to my public portfolio and your help is highly appreciated.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub