@pikapikamart
Posted
Hey, really nice work on this one. Just saw the site and it looks really great at desktop and mobile view and it is responsive as well which is really nice.
For some suggestions, here are some:
- If you zoom out on your screen, you will notice that the layout is not being centered vertically properly. You can add
justify-content: center
on thebody
tag so that it will be centered, also, you don't need theflex-direction: column
on thebody
since you only have a single child on it. If you remove this, just usealign-items: center
( though I know you already know this :> ); - For this one, you could just use a
main
tag and remove theheader
tag. Usually, a primaryheader
will only contain the top-most part of the site, including the website-logo, navlinks and other controls. On this one, the text that theheader
is wrapping is just the hero-text of the site, making it a part of themain
tag. - Each of the icons on the card are only acting as decorative image. Decorative images should be hidden for screen-reader at all times by using
alt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if you are usingsvg
instead ofimg
tag.
Just those ones since the sites looks really great from the start. Again, great job on this one.