Submitted about 2 months ago

Just CSS and HTML, its too small of a project to need ro add anything

Danijel Adrinek• 420

@DanijelAdrinek

Preview site View code

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I already made many projects, this wasnt a challange, I dont have anything to brag about in a project this small

What specific areas of your project would you like help with?

Well, if you do have suggestions on how to improve, I would like to hear :)

Community feedback

Harsh Kumar Dwivedi• 740

@Harsh-Kumar-Dwivedi

Posted about 2 months ago

Hi @DanijelAdrinek ,

I think you can prefer to replace <div class="card"> with <main> element and <div class="attribution"> with <footer> element. These will improve accessibility and make your markup more semantic.

Hope it is helpful !

Happy Coding !

Danijel Adrinek• 420

@DanijelAdrinek

Posted about 2 months ago

@Harsh-Kumar-Dwivedi thanks fam, on my last job, we mostly worked with Div's, my semantic HTML is slightly rusty, but I'll get it back, thanks for reminding me tho :)

Harsh Kumar Dwivedi• 740

@Harsh-Kumar-Dwivedi

Posted about 2 months ago

@DanijelAdrinek

Welcome

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord