Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Password Generator App with custom notification funcionality

bem
P
Carlos Samuel•350
@Crtykwod
A solution to the Password generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm most proud of how I implemented the dynamic password strength calculation system.

For example, this part of the code made me proud:

export const calculateStrength = () => {
  setStrength(strengths.filter((input) => input.checked).length);
  if (lengthValue < 12) return strength - 1;
  if (lengthValue > 16 && strength > 0) return strength + 1;
  return strength;
};

This implementation dynamically calculates password strength based on both the number of selected character types and password length, providing immediate visual feedback through the strength indicator bars.

What challenges did you encounter, and how did you overcome them?

The real-time slider animation with dynamic color gradients was a challenging aspect to implement correctly. I solved this by creating a function that calculates the percentage and updates the background gradient:

export const runSliderAnimation = () => {
  const value =
    ((lengthSlider.value - lengthSlider.min) /
      (lengthSlider.max - lengthSlider.min)) *
    100;
  lengthSlider.style.background = `linear-gradient(to right, var(--clr-neon-green) ${value}%, var(--clr-very-dark-gray) ${value}%)`;
};
What specific areas of your project would you like help with?

I would love feedback on the following areas:

Password Generation Algorithm:

The current implementation is basic and could be enhanced. How can I make it more secure and ensure better distribution of character types? Here's the current generation function:

export const generatePassword = () => {
  const charset = [
    "ABCDEFGHIJKLMNOPQRSTUVWXYZ",
    "abcdefghijklmnopqrstuvwxyz",
    "0123456789",
    "!@#$%^&*()_+-=[]{}|;:,.<>?/"
  ];

  const selectedCharsets = strengths
    .map((input, index) => input.checked ? charset[index] : '')
    .filter(set => set !== '')
    .join('');

  let password = "";
  for (let i = 0; i < lengthValue; i++) {
    const randomIndex = Math.floor(Math.random() * selectedCharsets.length);
    password += selectedCharsets.charAt(randomIndex);
  }
  return password;
};

Should I implement a more sophisticated algorithm that ensures at least one character from each selected type is included?

Accessibility Implementation:

While I've included ARIA attributes and screen reader support, I'm particularly interested in feedback on the strength indicator implementation:

<div class="strength" role="region" aria-label="Password strength indicator">
  <p class="strength__label">Strength</p>
  <div class="strength__meter">
    <p class="strength__value" id="strengthValue" aria-live="polite"></p>
    <div class="strength__indicator" id="strengthIndicator" role="progressbar" aria-label="Password strength bars">
      <div class="strength__bar"></div>
      <div class="strength__bar"></div>
      <div class="strength__bar"></div>
      <div class="strength__bar"></div>
    </div>
  </div>
</div>
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Anamay•450
    @anamaydev
    Posted about 2 months ago

    Your code looks great. I'm currently learning React, and I was wondering if you have any good resources on React or accessibility that you've found helpful?

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub