Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-overview-card-component

Maiphan 50

@Maipenrai23

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. The difficult point is responsive design while building the project responsive is the most difficult for me
  2. For the unsure code is the responsive part
  3. For questions I haven't yet, but I am really happy to welcome the trips or some suggestions or comments from experts or anyone, I will bring them to develop my skill, thank

Community feedback

IRVINE MESA 1,855

@DrMESAZIM

Posted

hi Maiphan

your solution looks very great . I liked everything especially the mobile responsiveness. I would like you to consider adding hover effect which changes the background color of the button when I hover through

If you find my suggestions difficult to implement . You can join us for our weekly live streams where we assists other developers by providing helpful reviews and feedback with live Frontend mentor code edits and reviews on this link. Your solution will also be reviewed and edited by myself live l ink here >> v https://youtube.com/live/L6WTd7HRTMM?feature=share

0

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
  • So fix it by replacing the element <div class="footer"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord