Submitted over 2 years ago

QR Code design using HTML and CSS

@prashantrishu

A solution to the QR code component challenge

Solution retrospective

Need more pointers on how to center elements in card like design and best practices. I am unsure whether assigning flexbox to body tag in this task is legit or good code or not. I also hard coded the size of the QR image; again unsure if it is right to do so.

Code

Please log in to post a comment

Community feedback

Lucas 👾•104,200
@correlucas
Posted over 2 years ago
👾Hello @prashantrishu, Congratulations on completing this challenge!

I’ve few suggestions for you that you can consider adding to your code:

1.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.
```
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
```
2.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

✌️ I hope this helps you and happy coding!
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord