Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component-main

@tania0808

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Mustapha 540

@muben88

Posted

Hi @tania0808, congrats on this solution, it looks perfect!

Just a small notice, you can fix accessibility issues by wrapping everything inside a main tag instead of using div, as it will be semantic. Also, try to use an h1 instead of an h4 tag, it's important to go from h1 ==> h5 as much as you can. And one last notice, it would be better if you used padding for the whole container div instead of using it on each element. Good luck!

Marked as helpful

0

@tania0808

Posted

@muben88 thanks! I'll try to fix it!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord