Responsive QR Code for Desktop and Mobile

Community feedback

• 

  P

  Øystein Håberg•13,260

  @Islandstone89

  Posted 7 months ago

  HTML:

  • Remove .container, it is not needed.

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • "Scan the QR code" is not a heading, but a paragraph, so change it to a <p>.

  • I would change the heading("Improve your") to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • There is no need to use Grid in this challenge, so remove those properties.

  • To center the card horizontally and vertically, with space between the <main> and the <footer>, I would use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  gap: 2rem;
  

  • Remove ALL widths and heights in px - you rarely need to set fixed sizes, and doing so can cause overflow.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add height: auto, display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

  00

  Marked as helpful
• 

  Oludare Suulola•170

  @osuulola

  Posted 7 months ago

  Way better than mine.

  10