Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 2 months ago

Single-Page-Design-Portfolio(HTML5, CSS3, JavaScript)

van-js
Eric Aguayo•1,055
@EAguayodev
A solution to the Single-page design portfolio challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of being able to create the JavaScript carousel from scratch and getting it to work smoothly using only 24 lines of vanilla JavaScript. It was a fun challenge to build a feature that's both interactive and responsive without relying on external libraries. If I were to do things differently next time, I’d focus more on accessibility—like adding keyboard navigation and ARIA roles to improve usability for all users. I’d also consider modularizing the JS code for better scalability and maintenance if the project were to grow.

What challenges did you encounter, and how did you overcome them?

One of the main challenges I encountered was getting all the CSS grid layouts to adapt properly across different screen sizes. I especially had trouble maintaining the original desktop layout without it breaking or overlapping when scaling down. I ended up keeping the desktop layout fairly similar to the tablet version to ensure consistent alignment. If anyone has suggestions or solutions on how to keep the original desktop grid structure while still allowing it to adapt seamlessly to each device size, I’d appreciate the feedback. It’s something I’d like to improve on in future projects.

What specific areas of your project would you like help with?

I’d appreciate feedback on two main areas. First, the CSS grid layout—I had some issues getting the grid to align properly across all device sizes, especially when trying to keep the desktop layout intact. If anyone has tips on making the layout more flexible while preserving design intent, I’d love to hear them. Second, I’d like some input on the JavaScript I wrote for the carousel. I managed to get it working with just 24 lines of vanilla JS, but in a real-world scenario, would this code be considered maintainable? Also, are there alternative approaches to creating an infinite carousel that can scroll in either direction without jumping back to the start image? Any feedback would be super helpful!

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on Eric Aguayo's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.