Skip to content
OverviewSolutions
3
Comments
3
P

Sascha Wagner

@Sascha-Wagner9970 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

Latest comments

  • D_One•30
    @D-One-Dev
    What are you most proud of, and what would you do differently next time?

    I'm proud of making my page adaptive by using percentage values and CSS media querries.

    What challenges did you encounter, and how did you overcome them?

    I had no access to the Figma design file, so I had to calculate all the values by eye.

    What specific areas of your project would you like help with?

    I have no particular questions, so any feedback is appreciated.

    Social links profile using flexbox

    1
    P
    Sascha Wagner•70
    @Sascha-Wagner99

    Hey Buddy, great work on the project! 🚀
    Here are a few suggestions you could consider to improve it further:

    • Try to get closer to the design specs. It need some time, but you will learn a lot.
    • Use lowercase letters for variable names to maintain uniformity. For example, instead of --Grey-700, --Grey-800, --Grey-900, use something like --green to keep the naming conventions consistent.
    • Consider adopting modern approaches like: 
      body {
    min-height: 100svh; /* Viewport height based on screen size */
}
    • Instead of buttons you can use <a>-Tags
    Marked as helpful
  • P
    Sascha Wagner•70
    @Sascha-Wagner99

    🌟 Hey, nice work!

    I noticed a few things that could be improved:

    • ❓ What's the sunny-gradient variable for?
      Maybe it was left in by accident?

    • 🧹 Redundant font files:
      If you're loading fonts via Google Fonts, you can safely remove the local font assets.

    • 🔤 Font units:
      You're using px units for font sizes. It's generally better to use relative units like rem or em for better accessibility and responsiveness.

  • Basmala sabra•80
    @Basmala-sabra
    What are you most proud of, and what would you do differently next time?

    The most proud of it is that I have coding the UI in a few hours.

    In the next time, I will make my project responsive to fit mobile and desktop devices.

    What challenges did you encounter, and how did you overcome them?

    I have forgotten about Flexbox and how to center the elements.

    I have reviewed Flexbox and returned to master it.

    What specific areas of your project would you like help with?

    Are there any improvements I can make in my code?

    How can I make my code more efficient or cleaner?

    HTML, CSS.

    1
    P
    Sascha Wagner•70
    @Sascha-Wagner99

    Not wrong, but I have learned you should use less id's and more classes... maybe something for ne next project to consider. In the design files are some properties for the text like

    • color
    • font-weight
    • line-height
    • letter-spacing In the design file was the pixel value for the font-size, but I like that you have used the rem unit for the fonts. Overall good job my friend :)
    Marked as helpful