Skip to content
OverviewSolutions
46
Comments
48

Adarsh

@adram3l3chIndia1,640 points

A self taught Graphic Designer and Frontend Developer from Kerala, India.

I’m currently learning...

the MERN stack

Latest solutions

View more solutions

Latest comments

  • Adarsh•1,640
    @adram3l3ch

    Hi Catherine you did a great job :) . You can sort out the border issue by making the border as a component itself and fetch about that country on that component. Also the problem of github pages with SPAs can be solved by using something like

    (function(l) {
        if (l.search[1] === '/' ) {
          var decoded = l.search.slice(1).split('&').map(function(s) { 
            return s.replace(/~and~/g, '&')
          }).join('?');
          window.history.replaceState(null, null,
              l.pathname.slice(0, -1) + decoded + l.hash
          );
        }
      }(window.location))

    You can refer about the same here

    Marked as helpful
  • Adarsh•1,640
    @adram3l3ch

    Hi Angela congrats on finishing the challenge. It seems like the image is missing. When I gone through your code I found the href you are using is /images/image-qr-code.png. The / means the root. When you host your site the root wont be your root folder. So you have to simply omit the / or simply use ./ instead of / which denotes the current folder.

    images/image-qr-code.png

    or

    ./images/image-qr-code.png

  • Adarsh•1,640
    @adram3l3ch

    Hi Bhremada Fevreano congratulations on finishing the challenge. Everything working just fine on all screen sizes. But It seems like from initial load infinite requests are sent to the server to fetch comments. Take a look at the problem. Also check the accessibility issues too.

    This thing not allowing me to submit the feedback since it is short so this is just blabbering dont care about this line

    Marked as helpful
  • Adarsh•1,640
    @adram3l3ch

    HI Catherine congratulations for finishing the challenge, you did a great job. I recommend the details tag for creating these kind of accordions. It is easier with the HTML elements "details" and "summary". In this way you can quickly create a perfomant and accessible accordion. CSS is only needed to create the accordion elements.

    You can refer about the details tag here

  • Adarsh•1,640
    @adram3l3ch

    It is caused by you've set position absolute to its child. Position absolute will take the element out of the flow. Since that div is the only child of main if it is gone main will feel empty :(

    Marked as helpful
  • Adarsh•1,640
    @adram3l3ch

    Your body now have a height equal to the card. So vertical align won't work. Give body height:100vh

    Marked as helpful
View more comments