Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

🎴 3-Column Preview Card Component

Patryk Besler•355
@beslerpatryk
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello! 👋

This is my " 3-Column Preview Card Component" solution using pure HTML and CSS. I used mostly CSS grid for layout and flexbox for inside elements. I am very happy with the outcome. Should I use the <img> tag for those icons or maybe there is a better way of doing it? Please share your suggestions! 😊 I tried to follow semantic markup rules and make my code as clean and easy to read as possible.

As always if you see any issues with this project - let me know. Any criticism/comments can certainly help me learn and grow as an aspiring front-end developer. Keep in mind that I always try to return the favor 😏

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted almost 4 years ago

    Hey, great work on this one. Layout in desktop is good and it responds well, the mobile layout is great as well.

    Regarding your question:

    • It is fine to use img tag on the icons, alternative is just creating a div to which uses that image as the background-image and on this one, both is fine, since the image is just decoration, you using alt="" on it is great.

    Some other suggestions would be:

    • I would not use section for each card, if I were to use section I would use 1 section to wrap all the cards, since it will be the card-collection-section. You use section to group related components that creates content on its own.
    • Avoid using height: 100% or height: 100vh on the html or the body or any element that is a large container. If you try to inspect your layout in dev tools at the bottom, you will notice that part of the layout is cut and can't be scrolled, since using that limits your element's height that is relative to the viewport's height, you could just remove it or replace it with min-height: 100vh, this will expand if it needs to.
    • Avoid using multiple h1 element on a webpage, always use only 1 h1. On this one, the h1 would be a screen-reader only text, have a look at Grace's solution inspect and look for the h1 element and see the css styling on it.

    Other than those, great job.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub