Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

🎴 3-Column Preview Card Component

@beslerpatryk

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello! 👋

This is my " 3-Column Preview Card Component" solution using pure HTML and CSS. I used mostly CSS grid for layout and flexbox for inside elements. I am very happy with the outcome. Should I use the <img> tag for those icons or maybe there is a better way of doing it? Please share your suggestions! 😊 I tried to follow semantic markup rules and make my code as clean and easy to read as possible.

As always if you see any issues with this project - let me know. Any criticism/comments can certainly help me learn and grow as an aspiring front-end developer. Keep in mind that I always try to return the favor 😏

Community feedback

@pikapikamart

Posted

Hey, great work on this one. Layout in desktop is good and it responds well, the mobile layout is great as well.

Regarding your question:

  • It is fine to use img tag on the icons, alternative is just creating a div to which uses that image as the background-image and on this one, both is fine, since the image is just decoration, you using alt="" on it is great.

Some other suggestions would be:

  • I would not use section for each card, if I were to use section I would use 1 section to wrap all the cards, since it will be the card-collection-section. You use section to group related components that creates content on its own.
  • Avoid using height: 100% or height: 100vh on the html or the body or any element that is a large container. If you try to inspect your layout in dev tools at the bottom, you will notice that part of the layout is cut and can't be scrolled, since using that limits your element's height that is relative to the viewport's height, you could just remove it or replace it with min-height: 100vh, this will expand if it needs to.
  • Avoid using multiple h1 element on a webpage, always use only 1 h1. On this one, the h1 would be a screen-reader only text, have a look at Grace's solution inspect and look for the h1 element and see the css styling on it.

Other than those, great job.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord