Michael• 240
@mksoofian
Posted
Hi @visualdenniss,
Your project looks great! The positioning and animations are near perfect.
Here are some constructive comments of what I found did not exactly meet the brief:
- The light box should only be showing when the large image is clicked. Your solution activates the light box when clicking a thumbnail when that should really be updating the large image.
- The Add to Cart button feature only populates a "1" in the qty bubble of the icon when it should reflect the number in the cart
- The qty in cart seems to be hard coded to "3" when it would ideally reflect the qty of the line item (connected to the qty bubble and the add to cart button)
- In addition to my previous note, the trash/delete icon should decrement the cart qty and register as "empty" when it reaches zero or empty
I think implementing the above improvements would really take your project to the next level. Good luck!
Marked as helpful
1
P
visualdennis• 8,295
@visualdenniss
Posted
@mksoofian Thanks a lot for taking your time to give a valuable feedback! Lot of great ideas!
I usually don't aim to exactly meet the brief, so my solutions usually deviate from it according to my preferences or what i think is alternatively good.
- Agreed, lightbox could be also shown when the large image is clicked.
- Qty bubble was a deliberate choice, it shows the number of unique kind of products, many websites do that. And if you click the cart, it shows the amount you selected from that kind of product. If you select 3 and add to cart, it will show price x 3.
- I couldn't find what part you are referring to as hardcoded. If you select some number of items and add to chart, to change the amount, u just need to delete it from the cart and select the amount again and then add to the cart. Amount itself is dynamically coded.
- Yes, this could be another idea, connecting the - + icons to the cart dynamically. It is a different system from what i did and i did not want to connect that way, but it is also viable alternative. Used by many sites too i think.
Thanks a lot again for your suggestions and ideas! Much appreciated 🙌 Happy coding!
1
