Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

- Intro component with sign up form solution

imad 1,550

@imadbg01

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View Challenge

Design Comparison

SolutionDesign

Report

0

Accessibility Issues

0

HTML Issues

View Report

imad’s questions for the community

I'm not sure if I get error message correct, I need more work on Js, please feel free to give your feedback!!

Community Feedback

Yuliya 230

@Ambrolla

Posted

Hello!

Answering your question about the behavior. Right when I press "submit", I only get 1 error. But when I click on the additional field, then I get an error in the fields where the info is missing. That's the only issue that you have :)

  1. Looking at code. I'm not familiar with gitlab, maybe they have something like gitignore, but I was curious why do you have assets folder?
  2. Don't forget to delete console.logs and your notes that aren't needed later from code :) Basically clean up and refactor code.
  3. Also, the hover/design is a bit different from the original :) For example, the button.

Marked as helpful

0


imad 1,550

@imadbg01

Posted

@Ambrolla Thanks a lot for your feedback, I will do some refactoring, and for gitlab you can just press . on your keyboard and will open on repository on IDE just like Github, or your can just clone repository to your local machine and for assets folder I use it to put all assets like images and css and design relevant files , just a way to try organizing a litter bit

0

Prince Roy 1,010

@iprinceroyy

Posted

hey @imadbg01, You need to focus on some here:

  1. You should use the font family which is provided in the style-guide.md file. First, you need to import that font link via CSS or HTML how to use google fonts.
  2. Don't use id as a selector. It's a bad practice.
  3. For handling validation, you can prefer my solution, It's simple & effective.
  4. CSS folder is not an asset, it's not a third-party folder; you created that. So it should be at the starting hierarchal level.

You did really excellent work, keep it up! Hope it adds to your learning, Happy Coding :)

0

Please focus on giving high-quality, helpful feedback and answering any questions imadbg01 might have. Here are some key points to consider:

  • Does the solution include semantic HTML?
  • Is it accessible, and what improvements could be made?
  • Does the layout look good on a range of screen sizes?
  • Is the code well-structured, readable, and reusable?

You can read our community guidelines if you're unsure what to post.

Slack logo

Join our Slack community

Join over 100,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!