13th challenge with pure JS and SCSS^

Solution retrospective
This challenge was really fun. My first draft was full of animation but I couldn't pull that one formula in terms of checking boundary so I had to remove it. Limited myself to using only few html elements. So I need to be very careful in my js since i'm just reusing those elements.
Anyway, have a look and drop your comments in my work^^. I will also create the spock version
Please log in to post a comment
Log in with GitHubCommunity feedback
- @bimalmagar10
@pikamart Hey! This is totally amazing. Good one and animations are impressive.One thing I pointed out is that the score isn't decremented when we lose the game. This is kinda weird, isn't it? The rest is fine and all good. Happy coding!
- @ApplePieGiraffe
Hello, Raymart Pamplona! 👋
Just came to check out another challenge of yours! 😀 Amazing work on this one! 👍 I really like the animations that you added and everything feels very nice and works well! 🤩 Keep up this great work! 🙌
And keep coding (and happy coding, too, of course)! 😁
- @DrKlonk
Hi Raymart!
Reaaaaaally well done on this one. Looks good, works good. A nice example for everyone to follow.
Particularly, I like the little animation on the 'rules' text and the fact that you don't get points reducted when you lose.
A minor thing I found in the scss: I think technically the flex classes like
flex--j-between
are utility classes and not variables. I'd expect a _variables.scss to contain only scss variables. But maybe that's just me. You could check out the 7-1 pattern to structure SCSS. I really like it.Just one minor thing I found in the code: in displayResult() the
winner
always gets set toplayerChoice
, although I don't think it affects anything.Again, very well done!
Cheers, Joran
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord