@ChrisAndrewsDev
Posted
Hi @MahmoudKasrawy!
It seems like your screenshot does not look the same as the deployed solution, I will just assume it's an error on this site, as the actual live solution looks much closer!
Very solid first effort 🎉🎉
You do have some HTML and accessibility issues that shouldn't be too hard to remedy.
Firstly, you should have meta attributes in your markup boilerplate, it would look something like this:
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
</body>
</html>
If you are using vsCode as your text editor, I think you can use "! + tab" to generate the default boilerplate markup which contains most (if not all) of the things you would need to avoid those errors!
When using an image, it's best-practice to provide an "alt" tag, to help with screen-readers and web-crawlers:
<img src="../source/image" alt="a text description of the image">
A really solid effort so far though!
@MahmoudKasrawy
Posted
@ChrisAndrewsDev Sir, thank you for these points. I will do the treatment👌
