Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

3 Card Column Layout - Mobile first, CSS Flexbox, Responsive Layout

Scott Tabor•150
@scottttabor
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Project done with raw HTML and CSS. My biggest questions I would love answered is how I am handling media queries and the way I construct my layout in general and from a responsive context. Any ways I can improve my code in a more efficient way? Open to all other suggestions as well!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted over 2 years ago

    Hi

    It looks like you've missed a few things in this or made some mistakes

    1. Border radius on the component is missing
    2. There's no margin on the component so it can hit screen edges, which you never want to happen
    3. You've used multiple h1s. You can't do that. A h1 is the single main title for a webpage. This would be a component within a web page, so the cards should have h2s
    4. You've used button elements for what should be anchor elements
    5. Remember to give the document a proper title
    6. It's invalid to have sections within a section like this. I'm not sure why you need that extra wrapper (carCard) at all to be honest
    7. You never ever need to use max-width: 100vw; (or width). Viewport units don't account for scrollbars or device notches so you'd never have a scenario where you'd want to ignore those as with 100vw. Main is full width by default anyway
    8. It is extremely unusual to camelCase class names like this. In more than a decade of dev work, I've never once seen a team that does that. Stick to usual code conventions, which also makes the classes easier to read - hyphenate class names (unless using a naming convention like BEM, which has specific hyphen and underscore patterns)
    9. Again you have more wrappers than necessary at the card level. You don't need vehicleCard then cardContainer nested inside that. Always keep the html structure as simple, minimal as possible
    10. NEVER limit the height of elements containing text like this
    11. Try to use rem more, eg for the max-width
    12. NEVER write font size in px. Extremely important because px will not honour people's font size settings. Use rem instead. Similar with line height and letter spacing - basically anything to do with fonts cannot use px, a fixed unit. Line height is usually unitless, like 1.5. Letter spacing is usually in em so it responds to the current font size
    13. The icons in this are decorative so must not have an alt value. That should be left intentionally blank
    14. The icons should have a fixed size, not in %. You always want to maintain control of icons like that. It's one of the only things you'll ever use fixed height and/or width for
    15. Hover styles should be on interactive elements on all screen sizes
    16. Your current hover effect is causing layout shift. This should never happen. To avoid it, make sure the element always has that border present.
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub