Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

3 Card Column with HTML-CSS challenge

Elia Niubo Burgos•30
@elianiubo
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi everyone, this is my first ever challenge, I did 2 online courses about HTML and CSS and this is the first time I put it in to practice. It took me a long time to do, and even though it's not perfect, I am happy with the result. I still need a lot to practice and improve, so whether you see any mistake or anything I should change or improve, your help would be much appreciate it.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Account deletedPosted about 4 years ago

    Hi, I think You did a good job, what you have to fix is the positioning, and center everything so that it stops going from side to side and for that I think flexbox would work.

    Happy Coding.

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted about 4 years ago

    Hey great work on this. Though upon loading, I get this pushed layout which causes that scrollbar at the bottom which we really want to avoid at all times and the mobile state as well is destroyed.

    Suggestions would be:

    1. To fix the layout. First.

    1.1. Remove the float: left on the different box.

    1.2. Remove the margin-left on the .wrap-box selector and set display: flex on it.

    1.3. Set display: grid; place-content: center; padding: 5rem 2rem; to the body tag to center the layout well and adding some paddings to it to prevent touching the sides, flooring and ceiling.

    1. As mentioned by fellow FEM, add border-radius to the corners.

    2. It will be better if you use h2 on the text title instead of h4. Though it is fine, but it is better to follow the ranking of the header tags right. Starting from h1 to h6.

    3. This is really important. Make those breakpoints. Create breakpoints where you think that the layout is shifting or getting destroyed and apply some custom layout on it. Then your mobile state, do not just set it to the 375px range, that is only the design, phone nowadays have higher ppi than that, so it will better for you to set the mobile breakpoint range on point 400px - 410px.

    If you need more help regarding those, just drop it here okay^

  • William Spanfelner•155
    @Will-1-Am
    Posted about 4 years ago

    Hey Elia, nice work on submitting your first challenge!

    Check-out this pen (https://codepen.io/will-1-am-the-Iceman/pen/gOgBrVP) for a suggestion on how to center everything horizontally and vertically - you can see the html and css and test til your heart's content. A border radius can be applied to a container wrapping the body contents to resolve the missing rounded corners.

    Hopefully, this will help you along on your coding journey.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub