Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 column card component

Szymonβ€’ 50

@smyku00

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas πŸ‘Ύβ€’ 104,580

@correlucas

Posted

πŸ‘ΎHello Szymon, congratulations for your solution!

You solution seems great, I saw that you've used mobile first to approach write your code. In overall your solution is okay. But look that your component changes to mobile too early and the card gets too big with the paragraph with a single line. My advice is that you set the media query for another breakpoint or give the property max-width to the paragraph to have all the text in the same line.

Try to use .class instead of id, id's are used for more specific things as forms and to recall Javascript, the class can get the work done in this smaller projects.

@media (min-width: 700px)
#container {
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
    max-width: 900px;
    margin: 0 auto;
}

Hope it helps, congrats for this amazing solution! Happy coding!

Marked as helpful

0
Fatβ€’ 850

@Fahatmah

Posted

KEEP UP THE GOOD WORK THERE!

But hey I saw you got some accessibility issues and it is said in your report is about your markup. It is recommended to practice of using Semantic HTML when you are writing your markup or your HTML file.

Nice work there. Keep it up!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord