3 Column Card (Vanilla CSS)

Community feedback

• 

  Adriano•42,870

  @AdrianoEscarabote

  Posted over 2 years ago

  Hi Michael, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  To make your project more similar to the layout in the example, add this property to the body:

  background-color: #F2F2F2;
  

  The rest is great!

  I hope it helps... 👍

  10

  Marked as helpful
• 

  PhoenixDev22•16,830

  @PhoenixDev22

  Posted over 2 years ago

  Hi Michael,

  Congratulation on finishing this challenge.

  Great job on this one! I have few suggestions regarding your solution:

  • About <h1>it is recommended not to have more than one h1 on the page. Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. In this challenge, as it’s not a whole page, you can have<h1>visually hidden with sr-only. Then you can swap those <h1> with <h2>.

  • In this challenge, the images are much likely to be decorative. For any decorative images, each img tag should have aria-hidden="true" attribute to make all web assistive technologies such as screen reader ignore those images .

  • In this challenge, what would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  • To know when to use one or the other in a specific situation, you must understand that every action on site falls under two different categories:

  1. Actions where users affect the website’s back-end or front-end.

  2. Actions where users won’t affect the website at all.

  Action where users affect the website itself is where you use a button. For example, sign-up and purchase actions are often buttons. The user in these situations are creating a new account and completing a monetary transaction, which are actions that affect the website’s back-end. Creating new posts or making comments are actions that change a website’s content and what the user sees.

  Actions where users won’t affect the website are where you use a link. These actions that take users from one page to another without changing anything on the website’s back or front-end.

  • On your buttons, add border: 2px solid transparent; to the regular state. This way when the hover on the buttons , it doesn't add an additional 4 pixels to the height and width making the elements shift.

  • Add border-radius and overflow hidden to the main container that wraps the three cards so you don't have to setborder-radiusto individual corners.

  • Consider using rem for font size .

  • Remember a modern css reset on every project that make all browsers display elements the same.

  • It's recommended to include a git ignore file. This came with your starter files and is extremely important as you move onto larger projects with build steps

  Hopefully this feedback helps.

  10

  Marked as helpful