@PhoenixDev22
Posted
Hello StrigZ, Your solution is really nice . I have few suggestions : HTML:
- Swap the buttons for anchor tags. Clicking those "learn more" buttons would trigger navigation not do an action so button elements would not be right.(buttons are for actions like opening a modal, submitting a form, toggling an element,)
-Whenever you include interactive elements (buttons, links, input, textarea), make sure you include clearly visible
focus-visible
styles as well as hover ones. This will make the users can navigate this website using keyboard (by using Tab key) easily. For future use , you have to specify the type of button .
To get rid of the accessibility issues you can add a <h1>
with class="sr-only"
(Hidden visually, but present for assistive tech).
`` .sr-only {
border: 0 !important;
clip: rect(1px, 1px, 1px, 1px) !important;
-webkit-clip-path: inset(50%) !important;
clip-path: inset(50%) !important;
height: 1px !important;
margin: -1px !important;
overflow: hidden !important;
padding: 0 !important;
position: absolute !important;
width: 1px !important;
white-space: nowrap !important;
} ``
This fairly modern technique will hide or clip content that does not fit into a 1-pixel visible area. Like off-screen content, it will be visually hidden but still readable by modern screen readers.
I really hope this feedback helps . happy and keep coding.
Marked as helpful
@StrigZ
Posted
@PhoenixDev22 Thank you!