Benjo Quilario• 1,810
@benjoquilario
Posted
Hey @Alexinzunzav Great job on finishing this one, It looks good
Some suggestion:
- Remove the
height: 100vhor just add themin-height: 100vhon the body tag. Because this will only limit the body to have a height 100% of the remaining viewport or screen. - Also avoid using
width: 100vwin a big container like body or main. Because it will only add a horizontal scroll bar. - Also must add the cursor: pointer on button, to inform the user that this is clickable and not just for design.
- Invalid property on * selector
border: border-box;box-sizing instead
Aside from those everything is good, keep coding and happy coding too!
Marked as helpful
1
Alex Inzunza• 80
@alexinzunza
Posted
@benjoquilario Hi Benjo, thanks for your comments! do you suggest that i have to use width: 100%; and height: 100%; instead?
0
Benjo Quilario• 1,810
@benjoquilario
Posted
@Alexinzunzav width:100% and min-height: 100vh instead, so that the element will expand if it needs to
Marked as helpful
0
