Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 column preview card using Flexbox

Deborah Robbianoโ€ข 600

@debriks

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi Guys! Received some very helpful feedback and refactored my first solution. I improved the HTML markup, changed some values that were still in px to relative units, removed the 'alt' attribute in the images as it was only decorative and changed the 'cursive' font property to 'sans-serif' to avoid getting 'Comic Sans'. Let me know if I missed something. Big thanks again to Lucas and Deniel!

Community feedback

Elaineโ€ข 11,420

@elaineleung

Posted

Great work Deborah! This looks really good, and I think the responsiveness is quite well done. I just got two suggestions:

  1. At around the 660px breakpoint when the layout changes, the sides of the component are touching the sides of the browser, so I'd probably just add some spacing to keep that from happening (maybe margin: 1rem would be good enough!)

  2. Your report is giving you some issues about missing alt tags, and actually even for decorative images, you still need the alt tag in the img, but you can keep it empty, like this: <img scr="image.png" alt="" >

Once again, well done here, and I'm glad you got improve upon your old solution!

Marked as helpful

1

Deborah Robbianoโ€ข 600

@debriks

Posted

@elaineleung Hi Elaine! Thank you to have taken the time to give me some feedback! I'm going to correct the code following your comments!

0
Divine Obetenโ€ข 2,435

@Deevyn9

Posted

Hi Deborah, congrats on completing this project, the buttons arenโ€™t displaying on mobile, 375px width using safari.

Hope you find the solution soon.

Good luck

Marked as helpful

1

Deborah Robbianoโ€ข 600

@debriks

Posted

@Deevyn9 Hi Divine! I'll look into it! Thank you for your feedback!

0
Lucas ๐Ÿ‘พโ€ข 104,560

@correlucas

Posted

๐Ÿ‘พHi Deborah Robbiano, congrats on completing this challenge!

Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you donโ€™t mind Iโ€™ve some tips for you:

To make your CSS code easier to work you can create a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

โœŒ๏ธ I hope this helps you and happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord