@folathecoder
Posted
Hi Erick!
Nice submission! Kudos! Your implementation looks nice and it responds well on all devices.
There are some tiny details you missed:
-
You used the wrong font family for your card headings. It ought to be "Big Shoulders Display".
-
The buttons are a bit bigger than the sketch, you can solve this by reducing the left-right padding to 30px or so, instead of 50px. As a Frontend Developer, you should always try to recreate a sketch design as it is. (Attention to details!)
-
You can work on accessibility by using rem instead of pixels.
-
You can also assign variables to your font family, just like you did for colors. This will make your work more maintainable and avoid repetition.
-
You can take full advantage of SCSS functionalities by using mixins for your media queries (if you want to!).
Overall, you have done well. Keep it up, Pal!
@erickcerna
Posted
@folathecoder Thanks for your comment. š I will continue learning about CSS.
