Zara Ag• 65
@szcompany
Posted
Congrats on finishing so fast.
It took me about an hour. I'll add some margins in mobile version. Overall all code is clean.
Have a nice weekend.
1
Design comparison
Solution retrospective
Hello everyone ! 🙂
I tried to tackle this challenge in around ~30min.
Any feedback is appreciated !
Have a nice day ☀️
Community feedback
Maksim Deviatilov• 185
@maksimcoder
Posted
Hello, Rayane, I was looking through your work after your comments on mine and spotted some issues. In mobile (375px) width, middle card top borders have radius, while two other cards don't. This is a little thing but still I wanted you to know it. 😁 Also, some margins, according to the mobile-design file, should be done. That's all I wanted to share with you, I take your work as a great example. Have a nice weekend!
1
Rayane• 1,935
@RayaneBengaoui
Posted
Hello @maksimcoder !
Thanks for commenting ! I made this choice intentionally because I think they are rounded on the design file. However, the second and the third one should have rounded top borders so it's strange that you only see it on the second one. I'll double check ! 😃 And you're right for the margins, I'll correct that.
Have a nice week-end ☀️
1
P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Hey, Enayar! 👋
Great job on yet another challenge! 🙌 This is a simple one—but overall, everything looks good and responds nicely (and doing it all in ~30 minutes is quite fast)! 😀
Of course, keep on coding (and happy coding, too)! 😁
1
Rayane• 1,935
@RayaneBengaoui
Posted
Hello @ApplePieGiraffe !
Thanks for your comment 🙂 Next one will probably be my first Guru challenge !
Have a nice week-end ☀️
1
P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
@RayaneBengaoui
Cool! 👍 Looking forward to seeing your next solution, then! 😀
Have a nice weekend, too! 🙌
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord