Lucas 👾• 104,580
@correlucas
Posted
👾Hello @markskwid, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
- The icon doesn’t have an important role when you think about semantics and the html structure. So you can add
aria-hidden=“true”to avoid it being found and read in the accessibility mode/screen readers. These are only decorative items. - To make your CSS code easier to work you can create a
single classto manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.
✌️ I hope this helps you and happy coding!
1
