3-column-preview-card-component

Please log in to post a comment
Log in with GitHubCommunity feedback
- @MelvinAguilar
Hi @JhonFXA👋, good job completing this challenge! 🎉
I have some suggestions you might consider to improve your code:
- The
<h1>
element is the main heading on a web page. There should only be one<h1>
tag per page. The HTML Section Heading elements (Reference). This case requires thatSUVS
,SEDANS
, andLUXURY
be<h2>
elements.
- The
Learn More
elements should be anchor tags and not buttons because they redirect to another website. Use buttons to perform actions such as displaying a modal, performing calculations. Use anchor tags to redirect users to a part of the page or to an external site.
- Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img src="./images/icon-sedans.svg" alt aria-hidden="true"> <img src="./images/icon-suvs.svg" alt aria-hidden="true" > <img src="./images/icon-luxury.svg" alt aria-hidden="true" >
Above all, the project is done well👏. I hope those tips will help you! 👍
Good job, and happy coding! 😁
Marked as helpful - The
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord