My solution to the 3 column previwe card challenge
Solution retrospective
English Version: After a while, this is another very good challenge to exercise knowledge. I didn't have much difficulty doing this exercise, it just took a little time to fit the divs into the mobile template.
Versão em Português: Depois de um tempo parado, esse é mais um desafio muito bom pra exercitar os conhecimentos. Não tive muitas dificuldades pra fazer esse exercício, apenas levou umk pouco de tempo para encaixar as divs no template mobile.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @MelvinAguilar
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 📄:
- You should use only one
<h1>tag per page. The<h1>tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires thatSedans,SUVsandLuxuryare headings, but you can use the<h2>tag instead of the<h1>tag. You can read more about this here 📘.
- You should use the
<a>tag instead of the<button>tag because theLearn Morebutton is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here 📘.
- The
<br>tag is not a semantic element. If a screen reader user is reading the page, they will hear "line break", which breaks the flow of the content. Instead, use CSS properties likemarginandpaddingto add vertical space between elements.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful - You should use only one
- @PedroBritoDEV
muito bom
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord