Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

3-column preview card component challenge

Tejaswini Labade•150
@TejaswiniLabade
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi,

I completed one more awesome challenge. I would really appreciate the feedback.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • PhoenixDev22•16,830
    @PhoenixDev22
    Posted over 3 years ago

    Hello @TejaswiniLabade ,

    I have some suggestions:

    • Body within the body sit:

    • <main>(which is the container of the three cards) instead of the <section>

    • <footer>(which is the FM attribution).

    • For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only.

    • In this case, you can have hidden< h1> with <sr-only> styling and make the other heading tags to <h2>.

    .sr-only {
    	border: 0 !important;
    	clip: rect(1px, 1px, 1px, 1px) !important; /* 1 */
    	-webkit-clip-path: inset(50%) !important;
    		clip-path: inset(50%) !important;  /* 2 */
    	height: 1px !important;
    	margin: -1px !important;
    	overflow: hidden !important;
    	padding: 0 !important;
    	position: absolute !important;
    	width: 1px !important;
    	white-space: nowrap !important;            /* 3 */
    } 
    
    • Swap the buttons for anchor tags. Clicking those"learn more"buttons would trigger navigation not do an action so button elements would not be right.

    • Instead of setting width in %, consider using max-width. That will let the component grow up to a point and be limited.

    • border-radiusand overflow hidden to the main container(that wraps the three cards.) so you don't have to set it to individual corners.

    Hopefully this feedback helps.

    Marked as helpful
  • Rio Cantre•9,650
    @RioCantre
    Posted over 3 years ago

    Hello there! Awesome job with this one. You did well on the design and viewing your code I would suggest the following for you...

    • Instead of wrapping the main-container with section you use main tag for readability
    • Clean the whitespaces in your code
    • Use a validator to check your solution

    Once again, Great job and Keep up the good work!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub