Fraser Watt• 1,790
@fraserwat
Posted
Hey ,this looks great!!
Couple of changes I'd make -
- On mobile view, the attribution footer element moves to the top of the screen? Also if you have it in a footer you can just give the footer a class of attribution, and get rid of the .attribution div.
- For a more responsive solution, I would change the
max-widthattribute on the.card__containerelement to 900px and get rid of the width, height and max-height attributes altogether. Especially when we have loads of components on the screen we don't want to be too prescriptive with heights and widths to give our designs as much flexibility as possible. - The breakpoint to the desktop media queries can probably come in at a smaller screen width
- Probably put a tiny bit more horizontal padding on the container element.
Looks fantastic though, keep it up!
Fraser
Marked as helpful
1
