Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3-column preview card component | Mobile First | CSS Flexbox

#accessibility
P
Mayank Aroraā€¢ 470

@mayankdrvr

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi Frontendmentor community,

This is my 3-column preview card component beginner challenge solution and my second submission. I request the community to review and give feedback for the live site and the shared source code on the following parameters-

  1. Does it follow all the good web accessibility practices?
  2. Is the site mobile first and responsive on all devices?
  3. Do all the padding, margin and border settings comply with the original design?
  4. Are all the colors and font settings matching the original design?
  5. Do you have any other code refactoring suggestion?

Please feel free and do not hesitate to review my code and do give feedback for improvement. All suggestions are welcome. Waiting to learn from your feedback and experience. Thank you for reviewing my challenge submission.

Community feedback

@VCarames

Posted

Hey there! šŸ‘‹ Here are some suggestions to help improve your code:

  1. No.
  2. No. From 370px - 460px, everything is squished.
  3. No. You are using padding-bottom for texts when you should be using margin instead.
  • Remove all the article you have added to your code; they are not being used correctly. In order to use the article element, the content has to make sense on its own and has to be independently distributable (the content can be placed on ANY site and still make sense).
  • The icons in this challenge are purely decorative which means that their alt tag should be left blank (alt="") to tell screenreader that is should be ignored.
  • The h1 heading is only allowed to be used once per page. In your content it is being used multiple times.
  • To properly center your content to your page, you will want to add the following to your body (this method uses CSS Grid):
body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
  • In modern Web Development, all content is built mobile first, in which you style for small screen first and use media-query to style for larger screens. This will ensure that performance and responsiveness are prioritized.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! šŸ‘¾

Marked as helpful

1

P
Mayank Aroraā€¢ 470

@mayankdrvr

Posted

Thank you @vcarames for the code review. I have implemented all the above suggestions according to my understanding and will try to keep them in my mind for my future challenges.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord