Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

3-column preview card component solution using html and css

vasileios•30
@vasilisalmpanis
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Let me know what you think about the way I did it and how I can impove.This is the second page i build. Thank you all in advance.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Account deletedPosted over 3 years ago

    Hi, your solution looks ok, but there's some things that need to be changed... so I gave your code some touch ups;

    • I removed a lot of things from overall-container as they weren't needed and I ended up with this;
    .overall-container {
      display: flex;
      justify-content: center;
      align-items: center;
      height: 100vh;
      width: 100vw;
    }
    
    
    • You shouldn't have put it in position : absolute as that takes the element out of the document flow... position : absolute should be avoided at all times unless you really need to use it.

    • & Flexbox centers it nicely so all that top, left position isn't necessary.

    • & with the cards, you could have just summed all of them up and gave them the same styling collectively instead of writing the same style for each and every card, so I did these changes;

    .sedan, .suv, .luxury {
      background-color:	#e38826;
      width: 250px;
      height: 300px;
      padding: 50px 20px 80px 20px;
      border-radius: 5px 0 0 5px;
      position: relative;
    }
    
    .suv {
      background-color: #006970;
      border-radius: 0;
    }
    
    .luxury {
      background-color: #004241;
      border-radius: 0 5px 5px 0;
    }
    
    
    • Next time to make it a whole lot cleaner you can give them the same class... this is a whole lot better because you write less, for more.

    You must also make it responsive because it currently isn't... I'll leave all that to you, it shouldn't be hard.

    Keep coding👍.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SASS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub