@AgataLiberska
Posted
Hi @under4, well done on this challenge, looks really good! A few things I noticed that you could work on
-
the column is not centered on larger screens
-
the layout goes from column to horizontal when there isn't quite enough space on the screen to display it correctly
-
many people don't consider using ids for styling to be a good practice, it would be better to have a separate class for each type of car and combine classes, or have a single class for cards and use pseudo selector
:nth-of-typeto set the backgrounds etc. -
you have a class of
containerthat you don't seem to be using at all? -
instead of setting
border-radiuson individual cards, set it on the containing div, and addoverflow: hiddento make sure that the cards don't cover the rounded corners of it.
Hope this helps :)
@under4
Posted
Hey @AgataLiberska thank you for the feedback. It seems that I misunderstood the container class. Thank you for clarifying it. I still dont have a grasp on good practises yet but with time and helpful people like you, i will.
Have an awesome day!
@AgataLiberska
Posted
@under4 no worries, happy to help! :)
