3-Column-Practice

Community feedback

• 

  Adriano•42,870

  @AdrianoEscarabote

  Posted over 2 years ago

  Hi Kevin Mainar Baguioso, how are you?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  2- All page content should be contained by landmarks, you can understand better by clicking here: click here

  I noticed that there were two scrollbars on the page, to fix this we can do the following.

  I added:

  * {
      margin: 0;
      padding: 0;
  }
  

  The rest is great!!

  Hope it helps...👍

  12

  Marked as helpful
• 

  Hyron•5,870

  @hyrongennike

  Posted over 2 years ago

  HI,

  Congrats on completing the challenge

  If you want center the columns or any child element you can use flexbox. You can add the following rules to your CSS file or make the appropriate change to yours.

  body {
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  
  .main-container {
      margin: 0 auto;
  }
  

  Hope this helpful. Let me know if you have any other questions.

  11

  Marked as helpful
• 

  Lucas 👾•104,160

  @correlucas

  Posted over 2 years ago

  👾Hello Kevin, Congratulations on completing this challenge!

  I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:

  You made your html structure entirely with div blocks but these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for each vehicle card you use <article> instead of the <div>.

  To make your CSS code easier to work you can create a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  00