Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3-column-preview-card

Xander.W 230

@XNWayne

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is much appreciated

Community feedback

Hania B. 1,360

@techanthere

Posted

Hey @XNWayne, since it's your first solution nice efforts put in, good job. Few problems which I found worth mentioning are:

  1. You are using id on all the elements for referring to in CSS. I know you will think but I need only one unique item so why not? But in real life projects, the id is used only when we need some Javascript to manipulate that element while classes are used all the time for styling. And the benefit is that through the use of classes, your code will become reusable.
  2. Since the icons can be treated only as the decorative content and you have set the alt empty as well, use aria-hidden="true" along with it so screen readers ignore these icons. This is a good practice for accessibility.
  3. You have not used a level 1 heading which is not required in design as well. But there should always be a h1 heading in the page and you can add an h1 tag with some contextual information about the page like you can say "Our cars features" etc. and then use sr-only class on that. You can also google for more on this...
  4. Your cards don't seem to be in the center, set min-height:100vh in body and some vertical and horizontal padding so the content is centered.
  5. The text "Learn More" should be enclosed by an anchor tag (a) instead of button, because this is more likely to result in a navigation to another page.
  6. And last thing is; never use px, instead em or rem units and they will scale the content automatically, I will prefer the rem units though.

Good luck!

Marked as helpful

0

Xander.W 230

@XNWayne

Posted

@techanthere Thank you very much for the tips much appreciated

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord