@PhoenixDev22
Posted
Hi Nassim,
First of all, Congratulation on completing this challenge and awesome work on this one. I have few suggestions regarding your solution:
- About
<h1>
it is recommended not to have more than one h1 on the page. Multiple<h1>
tags make using screen readers more difficult, decreasing your siteโs accessibility. You can have<h1>
visually hidden withsr-only
. Then swap those<h1>
by<h2>
.
- What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the
<a>
. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
- In this challenge, the images are much likely to be decorative. For any decorative images, each img tag should have empty
alt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site using target=โ_blankโ attribute , you can expose your site to performance and security issues.
Hopefully this feedback helps.
Marked as helpful