Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Cannot read properties of null (reading 'code')
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3-column-preview-card-component

#gulp#sass/scss#bem
Eve 10

@Evecreate

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Grace 27,710

@grace-snow

Posted

This looks like a nice neat solution when reviewing the code. Only a few small issues I spot with html

  • The buttons should be anchor tags I think. They would almost certainly trigger navigation to another page (unless you think they would do something different?)
  • Why h3s? At least wrap in a section with a visually hidden (sr-only) h2 to demonstrate that you think this component would sit lower down a real web page. I know this isn't a full webpage, so might not have a h1, but it is very important that headings go in order, so try to demonstrate that with your content (if in doubt, always choose a heading higher in the hierarchy like h2s for these headings, with an sr-only h1 above to name the component example)
  • Make sure you undate the attribution link to point somewhere - e.g. your Frontend Mentor profile or github profile page

Good job on the code though, it all looks very neat and easy to read

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord