@Nishkarsh01
Posted
Hello, Deepthi-Ramesh! 👋
Congrats on finishing your first frontend mentor challenge! Here are few suggestions from me:
- please do add the link to the GitHub repository so that we can view your code.
- update the background color of body to
background: hsl(0, 0%, 95%); - try giving the heading
font-family: 'Big Shoulders Display', cursive; - try reducing the height of each card.
- try fixing the ACCESSIBILITY ISSUES and HTML ISSUES mentioned in the report by frontend mentor.
Good luck with that, have fun coding! 💪
@Deepthi-Ramesh
Posted
@Nishkarsh01 Thank you for your suggestion.
@Deepthi-Ramesh
Posted
@Nishkarsh01 Hey hi ! Linked Github repository .Check out the code.
@Nishkarsh01
Posted
@Deepthi-Ramesh sure thing
@Nishkarsh01
Posted
@Deepthi-Ramesh
-
add this link
https://github.com/Deepthi-Ramesh/3-column-preview-card-component-mainin the solution to GitHub repository -
and this link
https://3-column-preview-card-component-main-lovat.vercel.app/to preview site.
@Nishkarsh01
Posted
Hello, ** Deepthi-Ramesh!** 👋
I really like how you've organized your code (a very good practice I must say), try using comments in CSS as well. Here are a few suggestions from me:
- Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
- Try using utility classes to avoid repetition of code and increase the reusability of code.
- It is advised that you do not use inline styling much, as it makes the code cluttery and is not the best practice.
- Try adding alt attributes to images, they improve accessibility.
Other than that really good job, keep hustling! 💪
@Deepthi-Ramesh
Posted
@Nishkarsh01 Hey hi !Thank you so much for you suggestions. I don't think will everyone spend their time to make others to do good pratice and to make others rectify their mistakes.Thank you so much .The reason behind not adding comments is that I does not know how to give a short explanation on each block of code.I will definitely try here after . I will try to learn everything what you said sir .Thank you🙂
@Nishkarsh01
Posted
@Deepthi-Ramesh Wishing you luck!
