3-column-preview-card-component using flex box html and css

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted about 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • Use only one <h1> tag per page. The <h1> tag is the most important heading tag, so using multiple <h1> tags can be confusing for screen readers and search engines. Instead, you can use <h2> tags for subheadings like "Sedans", "SUVs", and "Luxury". You can read more about this here 📘.

  • Use the <a> tag instead of the <button> tag. The "Learn More" element on your page is a link to another page, so it should use the <a> tag. You can use <button> tags for actions such as submitting a form or closing a modal. You can read more about this here 📘.

  • Use flexbox or grid layout to center your elements instead of using margins. The advantage of using these CSS properties is that they allow you to center elements both horizontally and vertically and are better suited for responsive design.

    body {
        min-height: 100vh;
        display: grid;
        place-content: center;
    }
    
    .container {
        /* margin: 21vh auto; */
    }
    

  I hope you find it useful! 😄

  Happy coding!

  44
• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
    margin: 21vh auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  • Additionally you want to add cursor: pointer for button element to ensure that's serve some purpose, because we want to use them wisely to improve user experience.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  10
• 

  idukpaye alex•685

  @Esesosa-max

  Posted about 2 years ago

  1. ✅ Responsive 4/5
  2. 🆗Good HTML Structure 3/5
  3. ✅Correct font and font-sizing 5/5
  4. ✅ More Accurate than the design 5/5
  5. ❌ Failed to give the button cursor:pointer on hover (yes I know it is a small detail)
  6. ❌ Wasn't impressed by the way you centered the whole thing

  10